cshannon commented on code in PR #1567:
URL: https://github.com/apache/activemq/pull/1567#discussion_r2635125549
##########
activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/KahaDBStore.java:
##########
@@ -109,8 +106,8 @@ public class KahaDBStore extends MessageDatabase implements
PersistenceAdapter,
protected ExecutorService queueExecutor;
protected ExecutorService topicExecutor;
- protected final List<Map<AsyncJobKey, StoreTask>> asyncQueueMaps = new
LinkedList<>();
- protected final List<Map<AsyncJobKey, StoreTask>> asyncTopicMaps = new
LinkedList<>();
+ final List<Map<AsyncJobKey, StoreTask>> asyncQueueMaps = new
LinkedList<>();
Review Comment:
All the scope changes were done because they were previously incorrect and
my IDE flagged it. In this case,
[AsyncJobKey](https://github.com/apache/activemq/blob/ef789aad2659334777657b779a6e00fe025937f0/activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/KahaDBStore.java#L1674)
is package scope and not protected.
It would is impossible for someone to extend the class and use AsyncJobKey
anyways, etc so changing the scope didn't cause problems. The two choices were
to narrow that line or to expand the scope and my preference is always to
narrow vs expand unless we need to. Generally speaking with KahaDB most things
should likely just be package scope anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
