jeanouii commented on code in PR #1659:
URL: https://github.com/apache/activemq/pull/1659#discussion_r2801444138
##########
activemq-client/src/main/java/org/apache/activemq/command/ActiveMQTextMessage.java:
##########
@@ -54,9 +54,11 @@ public Message copy() {
return copy;
}
- private void copy(ActiveMQTextMessage copy) {
- super.copy(copy);
- copy.text = text;
+ protected void copy(ActiveMQTextMessage copy) {
Review Comment:
The synchronized bellow on this is accurate because the other synchronized
methods are also on this. All good
Wondering why the internal copy(ActiveMQTexteMessage) moved from private to
protected?
I don't see subclasses or I missed it, so no reason to expose our internals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
