cshannon commented on PR #1659: URL: https://github.com/apache/activemq/pull/1659#issuecomment-3909774098
@pradeep85841 - Looking more at the tests and the changes, the synchronization keywords don't do anything (at least not for the test). It looks like what really fixes it is the change inside clearUnmarshalledState. https://github.com/apache/activemq/pull/1659/changes#diff-6cfa7d25bdb07827afcc060c572b2bed07850282c14893a05dd695fc63bbd5ddR159-R163 Normally if that is called the content should be there and not null, but that check handles in case it is null by making sure we marshal it first. Can you re-try without any synchronization and just that fix to see if it fixes your environment? If we really are copying on dispatch (and we are) and the copy is done by the broker it just doesn't seem like we should really need to add synchronization as the messages are meant to be used by one thread at a time and copied if multiple threads are touching them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
