pradeep85841 commented on code in PR #1659:
URL: https://github.com/apache/activemq/pull/1659#discussion_r2802090946
##########
activemq-client/src/main/java/org/apache/activemq/command/ActiveMQTextMessage.java:
##########
@@ -54,9 +54,11 @@ public Message copy() {
return copy;
}
- private void copy(ActiveMQTextMessage copy) {
- super.copy(copy);
- copy.text = text;
+ protected void copy(ActiveMQTextMessage copy) {
Review Comment:
@jeanouii That's a fair point regarding the visibility. I initially changed
it to protected to follow the pattern of the parent ActiveMQMessage copy logic,
but I agree that since there are no current subclasses of ActiveMQTextMessage,
it's better to keep it encapsulated.
I'm going to wait for @cshannon's final feedback before pushing any more
updates. This way, I can consolidate all requested changes—including reverting
this visibility to private—into a single final push to keep the history clean.
Thanks for catching that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
