ashutosh-bapat commented on a change in pull request #581: HIVE-21529 :
Bootstrap ACID tables as part of incremental dump.
URL: https://github.com/apache/hive/pull/581#discussion_r275282557
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/Utils.java
##########
@@ -196,6 +196,23 @@ public static boolean shouldReplicate(ReplicationSpec
replicationSpec, Table tab
}
return shouldReplicateExternalTables;
}
+
+ if (AcidUtils.isTransactionalTable(tableHandle.getTTable())) {
+ // For testing purposes only, do not replicate ACID tables when config
says so
+ boolean shouldReplicateAcidTables = true;
+ if (hiveConf.getBoolVar(HiveConf.ConfVars.HIVE_IN_TEST_REPL)) {
Review comment:
The idea is to use this flag only for testing and not expand its usage
beyond testing. So, as per discussion I have removed this flag from HiveConf
and defined in ReplUtils. We still use HIVE_IN_TEST_REPL to protect dump in
case the user is using REPL_DUMP_INCLUDE_ACID_TABLES in its config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
