ashutosh-bapat commented on a change in pull request #581: HIVE-21529 : Bootstrap ACID tables as part of incremental dump. URL: https://github.com/apache/hive/pull/581#discussion_r275287331
########## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpWork.java ########## @@ -65,11 +65,20 @@ int maxEventLimit() throws Exception { return maxEventLimit; } - void overrideEventTo(Hive fromDb) throws Exception { + void overrideEventTo(Hive fromDb, long bootstrapLastId) throws Exception { if (eventTo == null) { eventTo = fromDb.getMSC().getCurrentNotificationEventId().getEventId(); LoggerFactory.getLogger(this.getClass()) .debug("eventTo not specified, using current event id : {}", eventTo); } + + // If we are bootstrapping ACID tables, we need to restrict events only upto the event id at + // the beginning of the bootstrap dump. See bootstrampDump() for more details. + if (bootstrapLastId >= 0) { Review comment: Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org