ashutosh-bapat commented on a change in pull request #581: HIVE-21529 : Bootstrap ACID tables as part of incremental dump. URL: https://github.com/apache/hive/pull/581#discussion_r275282858
########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/CommitTxnHandler.java ########## @@ -107,12 +107,33 @@ public void handle(Context withinContext) throws Exception { if (!withinContext.hiveConf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY)) { + boolean replicatingAcidEvents = true; + if (withinContext.hiveConf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES)) { + // We do not dump ACID table related events when taking a bootstrap dump of ACID tables as + // part of an incremental dump. So we shouldn't be dumping any changes to ACID table as + // part of the commit. At the same time we need to dump the commit transaction event so + // that replication can end a transaction opened when replaying open transaction event. + LOG.info("writeEventsInfoList will be removed from commit message because we are " + Review comment: Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org