pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP 
execution latency metrics
URL: https://github.com/apache/hive/pull/633#discussion_r287777851
 
 

 ##########
 File path: 
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java
 ##########
 @@ -276,6 +302,43 @@ private void getTaskSchedulerStats(MetricsRecordBuilder 
rb) {
         .addCounter(SchedulerPendingPreemptionTaskCount, 
pendingPreemptionTasksCount.value())
         .addCounter(SchedulerPreemptedTaskCount, preemptedTasksCount.value())
         .addCounter(SchedulerCompletedDagCount, completedDagcount.value());
+    daemonTaskLatency.forEach((k, v) -> rb.addGauge(v, v.getMean()));
 
 Review comment:
   We need to add them as a gauge so it will show up on the counter /JMX list

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to