pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics URL: https://github.com/apache/hive/pull/633#discussion_r287778469
########## File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java ########## @@ -276,6 +302,43 @@ private void getTaskSchedulerStats(MetricsRecordBuilder rb) { .addCounter(SchedulerPendingPreemptionTaskCount, pendingPreemptionTasksCount.value()) .addCounter(SchedulerPreemptedTaskCount, preemptedTasksCount.value()) .addCounter(SchedulerCompletedDagCount, completedDagcount.value()); + daemonTaskLatency.forEach((k, v) -> rb.addGauge(v, v.getMean())); + } + + static class DaemonLatencyMetric implements MetricsInfo { + private String name; + private ExponentiallyDecayingReservoir reservoir; Review comment: Do not like Guava, and Stats appeared in guava 20. We are on 19 now and upgrading can cause problems with other projects like hadoop. Moved to using apache math DescriptiveStatistics instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org