sankarh commented on a change in pull request #664: HIVE-21762: REPL DUMP to
support new format for replication policy input to take included tables list.
URL: https://github.com/apache/hive/pull/664#discussion_r291878554
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java
##########
@@ -431,13 +474,13 @@ private void setConfigs(ASTNode node) throws
SemanticException {
// REPL STATUS
private void initReplStatus(ASTNode ast) throws SemanticException{
- dbNameOrPattern = PlanUtils.stripQuotes(ast.getChild(0).getText());
+ replScope.setDbName(PlanUtils.stripQuotes(ast.getChild(0).getText()));
Review comment:
I think, it is better to keep it as user have the additional support to
define pure table level replication by having one policy per table. We may
document this conflicting case. I believe DLM won't have this issue as they
always support DB level replication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
