sankarh commented on a change in pull request #664: HIVE-21762: REPL DUMP to
support new format for replication policy input to take included tables list.
URL: https://github.com/apache/hive/pull/664#discussion_r291878772
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/Utils.java
##########
@@ -88,18 +89,24 @@ public static void writeOutput(List<String> values, Path
outputFile, HiveConf hi
public static Iterable<String> matchesTbl(Hive db, String dbName, String
tblPattern)
throws HiveException {
if (tblPattern == null) {
- return getAllTables(db, dbName);
+ return getAllTables(db, dbName, null);
} else {
return db.getTablesByPattern(dbName, tblPattern);
}
}
- public static Collection<String> getAllTables(Hive db, String dbName) throws
HiveException {
+ public static Iterable<String> matchesTbl(Hive db, String dbName, ReplScope
replScope)
Review comment:
In case of bootstrap, db name inside ReplScope can be Db pattern. But dbName
passed here is each DB that matches the pattern. In bootStrapDump() method, we
can see the corresponding code. It is base code behaviour and so kept it same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
