sankarh commented on a change in pull request #664: HIVE-21762: REPL DUMP to
support new format for replication policy input to take included tables list.
URL: https://github.com/apache/hive/pull/664#discussion_r291878866
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
##########
@@ -891,13 +893,13 @@ replDumpStatement
@init { pushMsg("replication dump statement", state); }
@after { popMsg(state); }
: KW_REPL KW_DUMP
- (dbName=identifier) (DOT tblName=identifier)?
+ (dbName=identifier) (DOT tablePolicy=replTableLevelPolicy)?
Review comment:
I think, it is better to keep it pure table level as user will have the
additional support to define pure table level replication by having one policy
per table. We may document this conflicting case. I believe DLM won't have this
issue as they always support DB level replication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
