pvary commented on a change in pull request #691: HIVE-21911: Pluggable 
LlapMetricsListener on Tez side to disable / resize Daemons
URL: https://github.com/apache/hive/pull/691#discussion_r298935738
 
 

 ##########
 File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
 ##########
 @@ -4353,6 +4353,9 @@ private static void 
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
       new TimeValidator(TimeUnit.MILLISECONDS), "Collect llap daemon metrics 
in the AM every given milliseconds,\n" +
       "so that the AM can use this information, to make better scheduling 
decisions.\n" +
       "If it's set to 0, then the feature is disabled."),
+    
LLAP_TASK_SCHEDULER_AM_COLLECT_DAEMON_METRICS_LISTENER("hive.llap.task.scheduler.am.collect.daemon.metrics.listener",
 "",
 
 Review comment:
   Since all of the related configs currently has AM in the names, I would keep 
it this way and when we move this out then we can rename them as needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to