pvary commented on a change in pull request #691: HIVE-21911: Pluggable LlapMetricsListener on Tez side to disable / resize Daemons URL: https://github.com/apache/hive/pull/691#discussion_r298935935
########## File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapMetricsCollector.java ########## @@ -58,26 +61,44 @@ private final Map<String, LlapManagementProtocolClientImpl> llapClients; private final Map<String, LlapMetrics> instanceStatisticsMap; private final long metricsCollectionMs; + @VisibleForTesting + final LlapMetricsListener listener; Review comment: I was thinking about the same lines, but we do not need them now, so I decided to keep this as simple as possible ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
