pvary commented on a change in pull request #691: HIVE-21911: Pluggable
LlapMetricsListener on Tez side to disable / resize Daemons
URL: https://github.com/apache/hive/pull/691#discussion_r298936551
##########
File path:
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapMetricsCollector.java
##########
@@ -101,13 +122,27 @@ void collectMetrics() {
LlapDaemonProtocolProtos.GetDaemonMetricsResponseProto metrics =
client.getDaemonMetrics(null,
LlapDaemonProtocolProtos.GetDaemonMetricsRequestProto.newBuilder().build());
- instanceStatisticsMap.put(identity, new LlapMetrics(metrics));
-
+ LlapMetrics newMetrics = new LlapMetrics(metrics);
Review comment:
Yes, I see several use-cases where we need statistics without the listener.
For example: it might be good idea that when we chose a random node for task
execution we could distribute these tasks based on the available executors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
