jcamachor commented on a change in pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r332279696
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -4215,17 +4222,27 @@ public Table alterTable(String catName, String dbname,
String name, Table newTab
*/
public static String verifyStatsChangeCtx(String fullTableName, Map<String,
String> oldP, Map<String, String> newP,
long writeId, String
validWriteIds, boolean isColStatsChange) {
- if (validWriteIds != null && writeId > 0) return null; // We have txn
context.
+ if (validWriteIds != null && writeId > 0)
+ {
+ return null; // We have txn context.
+ }
String oldVal = oldP == null ? null :
oldP.get(StatsSetupConst.COLUMN_STATS_ACCURATE);
String newVal = newP == null ? null :
newP.get(StatsSetupConst.COLUMN_STATS_ACCURATE);
// We don't need txn context is that stats state is not being changed.
- if (StringUtils.isEmpty(oldVal) && StringUtils.isEmpty(newVal)) return
null;
+ if (StringUtils.isEmpty(oldVal) && StringUtils.isEmpty(newVal)) {
+ return null;
+ }
if (StringUtils.equalsIgnoreCase(oldVal, newVal)) {
- if (!isColStatsChange) return null; // No change in col stats or
parameters => assume no change.
+ if (!isColStatsChange)
+ {
Review comment:
Knitpick. Move to line above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
