jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332259393
########## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/IScheduledQueryMaintenanceService.java ########## @@ -0,0 +1,19 @@ +package org.apache.hadoop.hive.ql.schq; + +import org.apache.hadoop.hive.metastore.api.ScheduledQueryPollResponse; +import org.apache.hadoop.hive.metastore.api.ScheduledQueryProgressInfo; + +/** + * Interface to cover Scheduled Query source service + * + * Note that the main reason to have this layer is to make testing easier. Review comment: Since this is only used for testing purposes, I am not sure we need it... Why don't we just create the class that is needed for testing as a service that overrides `MetastoreBasedScheduledQueryService`? Otherwise, having an interface is not bad, but maybe you can delete this line in the comment... we may have a new implementation of the service in the future :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
