jcamachor commented on a change in pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r332263137
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -667,6 +667,19 @@ public static ConfVars getMetaConf(String name) {
RUNTIME_STATS_MAX_AGE("runtime.stats.max.age",
"hive.metastore.runtime.stats.max.age", 86400 * 3, TimeUnit.SECONDS,
"Stat entries which are older than this are removed."),
+ SCHEDULED_QUERIES_CRON_SYNTAX("scheduled.queries.cron.syntax",
"hive.metastore.scheduled.queries.cron.syntax",
+ "QUARTZ", new StringSetValidator("UNIX", "QUARTZ", "CRON4J", "SPRING"),
+ "Defines the format of the schedule expressions to be used in
scheduled queries."),
+
SCHEDULED_QUERIES_EXECUTION_PROGRESS_TIMEOUT("scheduled.queries.execution.timeout",
+ "hive.metastore.scheduled.queries.progress.timeout", 120,
TimeUnit.SECONDS,
+ "If a scheduled query is not making progress for this amount of time
it will be considered TIMED_OUT"),
+
SCHEDULED_QUERIES_EXECUTION_MAINT_TASK_FREQUENCY("scheduled.queries.execution.maint.task.frequency",
+ "hive.metastore.scheduled.queries.execution.clean.frequency", 60,
TimeUnit.SECONDS,
+ "Interval of scheduled query maintenance task. Which removes
executions above max age; and marks executions as timed out if the condition is
met"),
+ SCHEDULED_QUERIES_EXECUTION_MAX_AGE("scheduled.queries.execution.max.age",
+ "hive.metastore.scheduled.queries.execution.max.age", 3 * 86400,
TimeUnit.SECONDS,
Review comment:
This is three days. I think we should set it longer since sometimes it may
take more than three days to dig into a problem... We can set this to one month
by default? If there are too many events, maybe we can have two different
intervals, one for deleting `EXECUTING` events (more often) and one of the rest
(less often)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
