kgyrtkirk commented on a change in pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r335716046
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
 ##########
 @@ -2318,4 +2318,10 @@ public void addPropertyReadEntry(Map<String, String> 
tblProps, Set<ReadEntity> i
       }
     }
   }
+
+  protected void unparse() {
+    UnparseTranslator unparseTranslator = new UnparseTranslator(conf);
 
 Review comment:
   this method executes the unparse translations; having it like this enables 
to unparse any kind of BSA statement not just SA statements.
   
   I've renamed the method to `executeUnparseTranlations`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to