kgyrtkirk commented on a change in pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r335878812
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
 ##########
 @@ -2066,6 +2074,71 @@ dropMaterializedViewStatement
     : KW_DROP KW_MATERIALIZED KW_VIEW ifExists? viewName -> 
^(TOK_DROP_MATERIALIZED_VIEW viewName ifExists?)
     ;
 
+createScheduledQueryStatement
+@init { pushMsg("create scheduled query statement", state); }
+@after { popMsg(state); }
+    : KW_CREATE KW_SCHEDULED KW_QUERY name=identifier
+        scheduleSpec
+        executedAsSpec?
 
 Review comment:
   it was totally wrong...I left this open this issue to also fix that 
non-owner may modify - but it was working incorrectly.
   
   how it will work:
   * having `(CREATE|ALTER|DROP)_SCHEDULED_QUERY` controls if a user can use 
scheduled queries
   * the executed as is checked against admin
   * if the current user is not the same as the scheduled query owner (and not 
admin) alters should be denied.
   
   these things happen in `ScheduledQueryAnalyze`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to