kgyrtkirk commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r335876491
########## File path: ql/src/java/org/apache/hadoop/hive/ql/scheduled/ScheduledQueryExecutionService.java ########## @@ -106,6 +123,7 @@ private void processQuery(ScheduledQueryPollResponse q) { } } + //FIXME transition?( ) Review comment: sorry; I tend to leave markers for myself...I wanted to make sure I look at this again tomorrow - idea is to have some "transition" method which will change the state and also reports - so that the synch around a synch method will not be needed anymore ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org