odraese commented on a change in pull request #944: [Hive-22760] Adding Clock
based eviction strategy.
URL: https://github.com/apache/hive/pull/944#discussion_r395928629
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/MetadataCache.java
##########
@@ -406,7 +405,8 @@ private boolean lockBuffer(LlapBufferOrBuffers buffers,
boolean doNotifyPolicy)
for (int i = 0; i < bufferArray.length; ++i) {
if (lockOneBuffer(bufferArray[i], doNotifyPolicy)) continue;
for (int j = 0; j < i; ++j) {
- unlockSingleBuffer(buffer, true);
+ //@TODO this is a bug by it self.
Review comment:
I would suggest to either fix the bug while you're at it or to add more
documentation to this comment, why this is a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
