b-slim commented on a change in pull request #944: [Hive-22760] Adding Clock
based eviction strategy.
URL: https://github.com/apache/hive/pull/944#discussion_r396548828
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -4196,6 +4199,9 @@ private static void
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
LLAP_LRFU_BP_WRAPPER_SIZE("hive.llap.io.lrfu.bp.wrapper.size", 64, "thread
local queue "
+ "used to amortize the lock contention, the idea hear is to try
locking as soon we reach max size / 2 "
+ "and block when max queue size reached"),
+ LLAP_IO_MAX_CLOCK_ROTATION("hive.llap.io.clock.max.rotation",
Review comment:
Agree with you this is not for customer at all, it is more for dev nob in
case of issue we can push the nob on the customer side without deploying code.
Will add more comments about it. this makes me thing that we need to add some
annotation about what configs are suppose to be dev configs and the one that
can be used by customer. Any other suggestion will be welcomed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
