odraese commented on a change in pull request #944: [Hive-22760] Adding Clock
based eviction strategy.
URL: https://github.com/apache/hive/pull/944#discussion_r395923314
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java
##########
@@ -26,39 +26,71 @@
* using a real programming language.
*/
public abstract class LlapCacheableBuffer {
- protected static final int IN_LIST = -2, NOT_IN_CACHE = -1;
-
- /** Priority for cache policy (should be pretty universal). */
- public double priority;
- /** Last priority update time for cache policy (should be pretty universal).
*/
- public long lastUpdate = -1;
+ public static final int INVALIDATE_OK = 0, INVALIDATE_FAILED = 1,
INVALIDATE_ALREADY_INVALID = 2;
Review comment:
Question: what was the reason for negating the return codes. Maybe even more
important: why isn't this an enum?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
