scarlin-cloudera commented on a change in pull request #970: Hive 23100
URL: https://github.com/apache/hive/pull/970#discussion_r405705933
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSize.java
##########
@@ -183,4 +185,50 @@ public static Double averageTypeSize(RelDataType type) {
}
}
+ public static double typeSize(RelDataType type, Comparable value) {
Review comment:
All the values returned seem to be of type integer. I saw the caller
returns a double though. I suppose it's slightly more optimal to return a
double type rather than an int type, but seems a bit weird if this is a public
method that can be used by other classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
