jcamachor commented on a change in pull request #970: Hive 23100
URL: https://github.com/apache/hive/pull/970#discussion_r406503082
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSize.java
##########
@@ -183,4 +185,50 @@ public static Double averageTypeSize(RelDataType type) {
}
}
+ public static double typeSize(RelDataType type, Comparable value) {
Review comment:
The method was taken from Calcite's `RelMdSize` as is. Interestingly, I
realized that although constructor for super class is protected, I could reuse
it since HiveRelMdSize is extending the class. As a bonus, I could remove
`averageTypeSize` too that was there for legacy reasons and use the one in
`RelMdSize`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
