scarlin-cloudera commented on a change in pull request #970: Hive 23100
URL: https://github.com/apache/hive/pull/970#discussion_r405691900
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java
##########
@@ -1157,4 +1174,112 @@ public Void visitInputRef(RexInputRef inputRef) {
return inputRefSet;
}
}
+
+ /** Fixes up the type of all {@link RexInputRef}s in an
+ * expression to match differences in nullability.
+ *
+ * <p>Throws if there any greater inconsistencies of type. */
+ public static List<RexNode> fixUp(final RexBuilder rexBuilder,
Review comment:
Optional: Since the only thing we're fixing up is the nullability, do we
want to call it fixNullability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
