zabetak commented on a change in pull request #1186:
URL: https://github.com/apache/hive/pull/1186#discussion_r447547869
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
##########
@@ -900,13 +898,6 @@ private void updateTablePartitionColStats(RawStore
rawStore, String catName, Str
rawStore.getPartitionColumnStatistics(catName, dbName, tblName,
partNames, colNames, CacheUtils.HIVE_ENGINE);
Deadline.stopTimer();
sharedCache.refreshPartitionColStatsInCache(catName, dbName,
tblName, partitionColStats);
- Deadline.startTimer("getPartitionsByNames");
- List<Partition> parts = rawStore.getPartitionsByNames(catName,
dbName, tblName, partNames);
- Deadline.stopTimer();
- // Also save partitions for consistency as they have the stats state.
- for (Partition part : parts) {
- sharedCache.alterPartitionInCache(catName, dbName, tblName,
part.getValues(), part);
Review comment:
The explanation is hidden in the commit message :)
Using alterPartitionInCache is problematic:
1. It empties all relevant stats about partitions even those updated just
now.
2. It is not necessary since partitions were updated/refreshed just before
calling the method updateTablePartitionColStats via
[updateTablePartitions](https://github.com/apache/hive/blob/31ee14644bf6105360d6266baa8c6c8060d38ea3/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java#L870).
3. It is not meant to be used for syncing the cache but rather handle
updates in partitions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
