kishendas commented on a change in pull request #1186:
URL: https://github.com/apache/hive/pull/1186#discussion_r447985439
##########
File path:
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java
##########
@@ -136,17 +129,19 @@
MetaStoreTestUtils.setConfForStandloneMode(conf);
ObjectStore objectStore = new ObjectStore();
objectStore.setConf(conf);
- objectStore.dropTable(DEFAULT_CATALOG_NAME, db1Utbl1.getDbName(),
db1Utbl1.getTableName());
- Deadline.startTimer("");
- objectStore.dropPartitions(DEFAULT_CATALOG_NAME, db1Ptbl1.getDbName(),
db1Ptbl1.getTableName(), db1Ptbl1PtnNames);
- objectStore.dropTable(DEFAULT_CATALOG_NAME, db1Ptbl1.getDbName(),
db1Ptbl1.getTableName());
- objectStore.dropTable(DEFAULT_CATALOG_NAME, db2Utbl1.getDbName(),
db2Utbl1.getTableName());
- Deadline.startTimer("");
- objectStore.dropPartitions(DEFAULT_CATALOG_NAME, db2Ptbl1.getDbName(),
db2Ptbl1.getTableName(), db2Ptbl1PtnNames);
- objectStore.dropTable(DEFAULT_CATALOG_NAME, db2Ptbl1.getDbName(),
db2Ptbl1.getTableName());
- objectStore.dropDatabase(DEFAULT_CATALOG_NAME, db1.getName());
- objectStore.dropDatabase(DEFAULT_CATALOG_NAME, db2.getName());
+ for (String clg : objectStore.getCatalogs()) {
Review comment:
Why is this change required ? I think in the test case, it's preferable
to explicitly add drop statements , so that we know what's going on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
