szehonCriteo commented on pull request #1537: URL: https://github.com/apache/hive/pull/1537#issuecomment-708377965
HI Vihang, thanks for looking at the review. I took a look at failing test TestHiveMetastoreTransformation, I'm not at all familiar with the new feature, looked a bit for the specs and could not find it so I spent a bit of time on it.. What I found is that before, the test was actually testing the wrong thing, it was in fact setting the tableType as EXTERNAL but the DefaultMetastoreTransformer was actually treating it as MANAGED because of the very issue addressed by this PR. So I just updated the test to try to test the actual expected behavior of EXTERNAL tables (EXT_READ, EXT_WRITE capabilities) and the other test was putting transactional which is not allowed for EXTERNAL tables so I changed that as well. I could not reproduce the other error of the TransactionalKafkaWriterTest Submitting again to run tests (although they have been failing lately for a test framework reason, I think). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
