nrg4878 commented on pull request #1537: URL: https://github.com/apache/hive/pull/1537#issuecomment-716770245
@szehonCriteo Hi Szehon, How you been? yeah, it does seem a bit odd that the test sets the tableType=EXTERNAL_TABLE but add capabilities that are for typically set for MANAGED_TABLEs. I do think that changing the test output to whats in the fix is incorrect. The API is supposed to only return fields are not shielded by a bit mask. If you changed the tableType=MANAGED_TABLE, the test should pass as-is. Could you give that a try please? Also should HiveMetastore.isExternal() be removed entirely and use just MetastoreUtils.isExternal() instead ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
