szehon-ho edited a comment on pull request #1537: URL: https://github.com/apache/hive/pull/1537#issuecomment-733051181
Sorry I've been awhile. Thanks Naveen for taking a look. I had some free time today to take a look at the TestHiveMetstoreTransformer but am still a bit lost. I tried to set the table type to ManagedTable as you suggest, but the MetastoreDefaultTransformer actually transforms it back to External table by the time the assert happens (actually this should probably do it not via the properties but by the modeled TableType, but in this case it doesn't matter). Code: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDefaultTransformer.java#L596. So then after that , it run the asserts which fail as they seem to be testing for ManagedTable, unless I am mistaken. If you have some time to let me know anything else to try, would appreciate it. I haven't taken a look at Miguel's comments yet. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
