aasha commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r520299449
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -573,7 +573,7 @@ public void init() throws MetaException {
listeners.add(new SessionPropertiesListener(conf));
transactionalListeners =
MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
conf, MetastoreConf.getVar(conf,
ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners.add(0, new AcidEventListener(conf));
Review comment:
Also how do you make sure that notification event listener is added to
the end?
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -573,7 +573,7 @@ public void init() throws MetaException {
listeners.add(new SessionPropertiesListener(conf));
transactionalListeners =
MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
conf, MetastoreConf.getVar(conf,
ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners.add(0, new AcidEventListener(conf));
Review comment:
Good to add a test for the same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
