pgaref commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r521472364
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -571,9 +571,12 @@ public void init() throws MetaException {
listeners =
MetaStoreServerUtils.getMetaStoreListeners(MetaStoreEventListener.class, conf,
MetastoreConf.getVar(conf, ConfVars.EVENT_LISTENERS));
listeners.add(new SessionPropertiesListener(conf));
- transactionalListeners =
MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
- conf, MetastoreConf.getVar(conf,
ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners = new ArrayList() {{
Review comment:
Hey @pkumarsinha thanks for the PR -- along the same lines as @aasha ,
would it make sense to have have some checks in place ensuring some order
depending on the Listener type instead of just relying on the user (who will
highly likely ignore the conf comment you added above)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
