pkumarsinha commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r521492511



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -571,9 +571,12 @@ public void init() throws MetaException {
       listeners = 
MetaStoreServerUtils.getMetaStoreListeners(MetaStoreEventListener.class, conf,
           MetastoreConf.getVar(conf, ConfVars.EVENT_LISTENERS));
       listeners.add(new SessionPropertiesListener(conf));
-      transactionalListeners = 
MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
-          conf, MetastoreConf.getVar(conf, 
ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
-      transactionalListeners.add(new AcidEventListener(conf));
+      transactionalListeners = new ArrayList() {{

Review comment:
       @pgaref  Thanks for the review. 
   Currently, there are just two impl for transnational event listener in Hive 
. Out of that, AcidEventLisner is hard-coded to be included. The other one, 
DbNotificationListener is the one which will ideally end up getting configured 
if user choose  to do so. So the idea was,  unless a user writes a custom 
transnational event listener, this config can have at most one value as of now. 
Let me know your opinion with this context.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to