pgaref commented on a change in pull request #1823:
URL: https://github.com/apache/hive/pull/1823#discussion_r566867490
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##########
@@ -443,7 +444,8 @@ public void setBaseAndInnerReader(
return new OrcRawRecordMerger.KeyInterval(null, null);
}
- OrcTail orcTail = getOrcTail(orcSplit.getPath(), conf, cacheTag,
orcSplit.getFileKey()).orcTail;
+ VectorizedOrcAcidRowBatchReader.ReaderData orcReaderData =
Review comment:
This is one of the breaking ORC changes introduced by encryption support.
As Tail and thus StripeStatistics may be encrypted, we always need a reader
instance to retrieve them.
OrcTail maintained the API call for backwards compatibility but it still
expects a reader to actually retrieve the stats:
https://github.com/apache/orc/blob/d78cc39a9299b62bc8a5d8f5c3fac9201e03cb8b/java/core/src/java/org/apache/orc/impl/OrcTail.java#L210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
