pgaref commented on a change in pull request #1823:
URL: https://github.com/apache/hive/pull/1823#discussion_r567800512
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java
##########
@@ -82,8 +82,7 @@ public void put(Path path, OrcTail tail) {
if (bb.capacity() != bb.remaining()) {
throw new RuntimeException("Bytebuffer allocated for path: " + path + "
has remaining: " + bb.remaining() + " != capacity: " + bb.capacity());
}
- cache.put(path, new TailAndFileData(tail.getFileTail().getFileLength(),
- tail.getFileModificationTime(), bb.duplicate()));
+ cache.put(path, new TailAndFileData(bb.limit(),
tail.getFileModificationTime(), bb.duplicate()));
Review comment:
But I agree, cache should be populated with the original
**getFileTail().getFileLength()** as it is afterward used for comparison (thus
reverted this change) -- however, where ReaderImpl.extractFileTail is now
called uses the buffer size instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
