mustafaiman commented on a change in pull request #1823:
URL: https://github.com/apache/hive/pull/1823#discussion_r568157322
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -4509,7 +4509,7 @@ private static void populateLlapDaemonVarsSet(Set<String>
llapDaemonVarsSetLocal
"Minimum allocation possible from LLAP buddy allocator. Allocations
below that are\n" +
"padded to minimum allocation. For ORC, should generally be the same
as the expected\n" +
"compression buffer size, or next lowest power of 2. Must be a power
of 2."),
- LLAP_ALLOCATOR_MAX_ALLOC("hive.llap.io.allocator.alloc.max", "16Mb", new
SizeValidator(),
+ LLAP_ALLOCATOR_MAX_ALLOC("hive.llap.io.allocator.alloc.max", "4Mb", new
SizeValidator(),
Review comment:
I still do not understand why we need to change LLAP Allocator's maximum
allocation size. Does LLAP allocator serve only ORC writers? I think it is used
for other buffer needs too.
Hive depends on ORC. So I dont understand how ORC uses
LLAP_ALLOCATOR_MAX_ALLOC for anything. We pass orc writers the appropriate
configs. If ORC writers need smaller buffer, we can configure that for those
writers via WriterOptions. There is no need to change llap allocator's settings
for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
