deniskuzZ commented on a change in pull request #1979:
URL: https://github.com/apache/hive/pull/1979#discussion_r576643788
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -469,6 +469,12 @@ private boolean isEligibleForCompaction(CompactionInfo ci,
ShowCompactResponse c
"=true so we will not compact it.");
return false;
}
+ if (AcidUtils.isInsertOnlyTable(t.getParameters()) && !HiveConf
Review comment:
what kind of underlying bug? in most cases query based compaction is
used for full acid tables as well. this config looks like a real hack to ignore
the problem that over time could lead to a more serious issue with accumulated
data to be compacted and performance degradation. If we want to improve
compaction usability I don't think that's a good approach, but that's just my
10 cents. From code point of view patch looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
