klcopp commented on a change in pull request #1979:
URL: https://github.com/apache/hive/pull/1979#discussion_r576972366
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -469,6 +469,12 @@ private boolean isEligibleForCompaction(CompactionInfo ci,
ShowCompactResponse c
"=true so we will not compact it.");
return false;
}
+ if (AcidUtils.isInsertOnlyTable(t.getParameters()) && !HiveConf
Review comment:
@deniskuzZ I guess the original intent for this config was as a feature
flag. Since compaction _is_ unreliable at the moment I don't think it's a
tragedy if we keep it for a bit longer. Why don't we open a ticket for its
removal and do it when we feel ready?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
