pvargacl commented on a change in pull request #1979:
URL: https://github.com/apache/hive/pull/1979#discussion_r576668055
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -469,6 +469,12 @@ private boolean isEligibleForCompaction(CompactionInfo ci,
ShowCompactResponse c
"=true so we will not compact it.");
return false;
}
+ if (AcidUtils.isInsertOnlyTable(t.getParameters()) && !HiveConf
Review comment:
1. This switch is already there it will just cause ClassCastException,
rather than handle this properly
2. This customer is using MR based compaction which works fine, the problem
is for mm tables the system will run query based no matter what, we want to
turn off query based compaction for every table, until they can get the fix to
their cluster, which is a very valid thing to do, otherwise compaction will not
run for anything.
3. Using a switch like this until the upgrade is much better solution then
disabling it off for 1000+ tables manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
