belugabehr commented on a change in pull request #1946:
URL: https://github.com/apache/hive/pull/1946#discussion_r581255309
##########
File path:
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##########
@@ -147,15 +151,81 @@
protected ThreadLocal<ServerContext> currentServerContext;
+ /**
+ * A context container for information related to client connections to the
+ * Thrift server.
+ */
static class ThriftCLIServerContext implements ServerContext {
- private SessionHandle sessionHandle = null;
- public void setSessionHandle(SessionHandle sessionHandle) {
- this.sessionHandle = sessionHandle;
+ private final long createTime;
+ private final Collection<SessionHandle> hiveSessionHandles;
Review comment:
Hey Peter, so it certainly is possible in Hive, the API exists, but I
just looked at the JDBC code and the JDBC code does not allow new sessions on
the same connection. I'm a bit torn on it. My gut tells me that that since
the API allows it, we allow for it here. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
