pvary commented on a change in pull request #1946:
URL: https://github.com/apache/hive/pull/1946#discussion_r582340792
##########
File path:
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##########
@@ -147,15 +151,81 @@
protected ThreadLocal<ServerContext> currentServerContext;
+ /**
+ * A context container for information related to client connections to the
+ * Thrift server.
+ */
static class ThriftCLIServerContext implements ServerContext {
- private SessionHandle sessionHandle = null;
- public void setSessionHandle(SessionHandle sessionHandle) {
- this.sessionHandle = sessionHandle;
+ private final long createTime;
+ private final Collection<SessionHandle> hiveSessionHandles;
Review comment:
I feel that the Hive code is complicated enough as it is. I would try to
add complexity when is absolutely needed.
If we know of a customer workload where it is used like this, then go ahead
and add the List. OTOH if we only find a non-trivial use-case for it, and it is
not for correctness, but more for "possible help later" then I would try to
avoid it.
Your thoughts?
Thanks,
Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
