belugabehr commented on a change in pull request #1946:
URL: https://github.com/apache/hive/pull/1946#discussion_r581262921
##########
File path:
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##########
@@ -147,15 +151,81 @@
protected ThreadLocal<ServerContext> currentServerContext;
+ /**
+ * A context container for information related to client connections to the
+ * Thrift server.
+ */
static class ThriftCLIServerContext implements ServerContext {
- private SessionHandle sessionHandle = null;
- public void setSessionHandle(SessionHandle sessionHandle) {
- this.sessionHandle = sessionHandle;
+ private final long createTime;
+ private final Collection<SessionHandle> hiveSessionHandles;
Review comment:
Here is the relevant code... it does not look like there are any error
conditions barring a user from calling `openSession` multiple times on the same
connection. It just creates a new session and binds it to the connection.
https://github.com/apache/hive/blob/5ab73120605076c1afc65951bcca06045f532683/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java#L337-L341
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
