hmangla98 commented on a change in pull request #2101:
URL: https://github.com/apache/hive/pull/2101#discussion_r616280662
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -8582,7 +8582,8 @@ public GetOpenTxnsInfoResponse get_open_txns_info()
throws TException {
public OpenTxnsResponse open_txns(OpenTxnRequest rqst) throws TException {
OpenTxnsResponse response = getTxnHandler().openTxns(rqst);
List<Long> txnIds = response.getTxn_ids();
- if (txnIds != null && listeners != null && !listeners.isEmpty()) {
+ boolean isHiveReplTxn = rqst.isSetReplPolicy() && rqst.getTxn_type() ==
TxnType.DEFAULT;
Review comment:
rqst variable can be of different types (OpenTxnRequest/
CommitTxnRequest/ AbortTxnRequest). So, this statement may not be generalised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
