hmangla98 commented on a change in pull request #2101:
URL: https://github.com/apache/hive/pull/2101#discussion_r621754207



##########
File path: 
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -1645,15 +1644,20 @@ public void testHdfsMaxDirItemsLimitDuringIncremental() 
throws Throwable {
     WarehouseInstance.Tuple incrementalDump2 = primary.run("use " + 
primaryDbName)
             .dump(primaryDbName, dumpClause);
 
-    eventCount = Integer.parseInt(incrementalDump2.lastReplicationId)
-            - Integer.parseInt(incrementalDump1.lastReplicationId);
-    assertTrue(eventCount > 5);
+    eventCount = getNoOfEventsDumped(incrementalDump2.dumpLocation);
+    assertTrue(eventCount > 5 && eventCount < 1000);

Review comment:
       This test is to assert that no of events dumped cannot be greater than 
(DFS_MAX_DIR_ITEMS_CONFIG - RESERVED_DIR_ITEMS_COUNT). For this particular run 
of repl dump (line no. 1645), This value is 1000 which was initially 5 for the 
previous run. So, no of events should be greater than 5 and less than 1000.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to