pkumarsinha commented on a change in pull request #2101:
URL: https://github.com/apache/hive/pull/2101#discussion_r618069326
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
##########
@@ -525,6 +532,9 @@ public void commitTxn() throws LockException {
LOG.debug("Committing txn " + JavaUtils.txnIdToString(txnId));
CommitTxnRequest commitTxnRequest = new CommitTxnRequest(txnId);
commitTxnRequest.setExclWriteEnabled(conf.getBoolVar(HiveConf.ConfVars.TXN_WRITE_X_LOCK));
+ if (replPolicy != null) {
Review comment:
Is default not NULL? This check seems to be not required
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -809,7 +810,7 @@ public void testOpenTxnEvent() throws Throwable {
primary.dump(primaryDbName);
long lastReplId = Long.parseLong(bootStrapDump.lastReplicationId);
- primary.testEventCounts(primaryDbName, lastReplId, null, null, 22);
+ primary.testEventCounts(primaryDbName, lastReplId, null, null, 16);
Review comment:
How many dump open/commit considered here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
