pvary commented on a change in pull request #2261:
URL: https://github.com/apache/hive/pull/2261#discussion_r632405632
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java
##########
@@ -284,4 +334,42 @@ private static String getCatalogType(Configuration conf,
String catalogName) {
}
}
}
+
+ public static class TableCache {
+ private static final Cache<String, Table> tableCache =
Caffeine.newBuilder()
+ .expireAfterAccess(12, TimeUnit.HOURS).build();
+ private static final Logger LOG =
LoggerFactory.getLogger(TableCache.class);
+
+ public static void removeTables(Configuration conf) {
+ String queryId = conf.get(HiveConf.ConfVars.HIVEQUERYID.varname);
+ if (queryId != null && !queryId.isEmpty()) {
+ Set<String> queryKeys = tableCache.asMap().keySet().stream()
+ .filter(k -> k.startsWith(queryId)).collect(Collectors.toSet());
+ tableCache.invalidateAll(queryKeys);
+ } else {
+ LOG.warn("Query id is not present in config, therefore no Iceberg
table object is removed " +
+ "from the table cache.");
+ }
+ }
+
+ public static Table getTable(Configuration conf, String catalogName,
String tableIdentifier) {
+ String queryId = conf.get(HiveConf.ConfVars.HIVEQUERYID.varname);
+ if (queryId != null && !queryId.isEmpty()) {
+ return tableCache.getIfPresent(getKey(queryId, catalogName,
tableIdentifier));
+ }
+ return null;
+ }
+
+ public static void addTable(Configuration conf, String catalogName, String
tableIdentifier, Table table) {
Review comment:
Why not use lambda to generate the table object if not present? Like it
is done with `putIfAbsent`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
