pvary commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r632408645
########## File path: iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerTestUtils.java ########## @@ -68,6 +68,7 @@ static TestHiveShell shell(Map<String, String> configs) { TestHiveShell shell = new TestHiveShell(); shell.setHiveConfValue("hive.notification.event.poll.interval", "-1"); shell.setHiveConfValue("hive.tez.exec.print.summary", "true"); + shell.setHiveConfValue("hive.query.lifetime.hooks", HiveIcebergQueryLifeTimeHook.class.getName()); Review comment: Maybe not here, but maybe a single big `hive.iceberg.enable` config should add all the required iceberg configs when the HS2 is started/or a query is executed... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org