lcspinter commented on a change in pull request #2261:
URL: https://github.com/apache/hive/pull/2261#discussion_r634341370
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java
##########
@@ -284,4 +334,42 @@ private static String getCatalogType(Configuration conf,
String catalogName) {
}
}
}
+
+ public static class TableCache {
+ private static final Cache<String, Table> tableCache =
Caffeine.newBuilder()
+ .expireAfterAccess(12, TimeUnit.HOURS).build();
+ private static final Logger LOG =
LoggerFactory.getLogger(TableCache.class);
+
+ public static void removeTables(Configuration conf) {
+ String queryId = conf.get(HiveConf.ConfVars.HIVEQUERYID.varname);
+ if (queryId != null && !queryId.isEmpty()) {
+ Set<String> queryKeys = tableCache.asMap().keySet().stream()
+ .filter(k -> k.startsWith(queryId)).collect(Collectors.toSet());
+ tableCache.invalidateAll(queryKeys);
+ } else {
+ LOG.warn("Query id is not present in config, therefore no Iceberg
table object is removed " +
Review comment:
No, we don't except, but I guess we should signal that the query id is
not present config, which could lead to cache pollution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
